Class InefficientInitializationInsideLoop

java.lang.Object

edu.umd.cs.findbugs.visitclass.BetterVisitor

edu.umd.cs.findbugs.visitclass.PreorderVisitor

edu.umd.cs.findbugs.visitclass.AnnotationVisitor

edu.umd.cs.findbugs.visitclass.DismantleBytecode

edu.umd.cs.findbugs.BytecodeScanningDetector

edu.umd.cs.findbugs.bcel.OpcodeStackDetector

edu.umd.cs.findbugs.detect.InefficientInitializationInsideLoop

All Implemented Interfaces:

Detector, Priorities, org.apache.bcel.classfile.Visitor

public class InefficientInitializationInsideLoop
extends OpcodeStackDetector

Nested Class Summary

Nested classes/interfaces inherited from class OpcodeStackDetector

OpcodeStackDetector.WithCustomJumpInfo

Field Summary

Fields

Modifier and Type	Field	Description
private final BugReporter	bugReporter
private SortedMap<Integer,Integer>	conditions
private static final Set<MethodDescriptor>	implicitPatternMethods
private SortedMap<Integer, BugInstance>	matched
private static final List<MethodDescriptor>	methods
private static final MethodDescriptor	NODELIST_GET_LENGTH
private static final MethodDescriptor	PATTERN_COMPILE
private static final MethodDescriptor	PATTERN_COMPILE_2
private static final MethodDescriptor	PATTERN_MATCHES
private SortedMap<Integer,Integer>	sources
private static final MethodDescriptor	STRING_MATCHES
private static final MethodDescriptor	STRING_REPLACEALL
private static final MethodDescriptor	STRING_REPLACEFIRST
private static final MethodDescriptor	STRING_SPLIT
private static final MethodDescriptor	STRING_SPLIT_2

Fields inherited from class OpcodeStackDetector

stack

Fields inherited from class DismantleBytecode

codeBytes, lineNumberTable, M_BR, M_CP, M_INT, M_PAD, M_R, M_UINT

Fields inherited from interface Priorities

EXP_PRIORITY, HIGH_PRIORITY, IGNORE_PRIORITY, LOW_PRIORITY, NORMAL_PRIORITY

Constructor Summary

Constructors

Constructor	Description
InefficientInitializationInsideLoop(BugReporter bugReporter)

Method Summary

Modifier and Type	Method	Description
private String	getFirstArgument()
private boolean	hasConstantArguments()
private boolean	isFastPath(String regex)	Since JDK 1.7 there's a special branch in String.split which works very fast for one-character pattern We do not report a bug if this case takes place (in fact precompilation will make split much slower since this fast path doesn't use regexp engine at all)
void	sawOpcode(int seen)	By default, this method will not be called when stack is TOP.
void	visitClassContext(ClassContext classContext)	Visit the ClassContext for a class which should be analyzed for instances of bug patterns.
void	visitMethod(org.apache.bcel.classfile.Method obj)

Methods inherited from class OpcodeStackDetector

afterOpcode, beforeOpcode, getStack, isUsingCustomUserValue, visitCode

Methods inherited from class BytecodeScanningDetector

getClassContext, report, shouldVisitCode

Methods inherited from class DismantleBytecode

areOppositeBranches, atCatchBlock, getBranchFallThrough, getBranchOffset, getBranchTarget, getClassConstantOperand, getClassDescriptorOperand, getCodeByte, getConstantRefOperand, getDefaultSwitchOffset, getDottedClassConstantOperand, getFieldDescriptorOperand, getIntConstant, getLongConstant, getMaxPC, getMethodDescriptorOperand, getNameConstantOperand, getNextCodeByte, getNextOpcode, getNextPC, getOpcode, getPC, getPrevOpcode, getRefConstantOperand, getRefFieldIsStatic, getRegisterOperand, getSigConstantOperand, getStringConstantOperand, getSwitchLabels, getSwitchOffsets, getXClassOperand, getXFieldOperand, getXMethodOperand, isBranch, isMethodCall, isRegisterLoad, isRegisterStore, isRegisterStore, isReturn, isShift, isSwitch, isWideOpcode, printOpCode, sawBranchTo, sawClass, sawDouble, sawField, sawFloat, sawIMethod, sawInt, sawLong, sawMethod, sawRegister, sawString, visit

Methods inherited from class AnnotationVisitor

getAnnotationParameterAsEnum, getAnnotationParameterAsString, getAnnotationParameterAsStringArray, visitAnnotation, visitAnnotation, visitParameterAnnotation, visitParameterAnnotation, visitSyntheticParameterAnnotation

Methods inherited from class PreorderVisitor

amVisitingMainMethod, asUnsignedByte, doVisitMethod, getClassDescriptor, getClassName, getCode, getConstantPool, getDottedClassName, getDottedFieldSig, getDottedMethodSig, getDottedSuperclassName, getField, getFieldDescriptor, getFieldIsStatic, getFieldName, getFieldSig, getFullyQualifiedFieldName, getFullyQualifiedMethodName, getMethod, getMethodDescriptor, getMethodName, getMethodSig, getMethodVisitOrder, getNumberArguments, getNumberMethodArguments, getPackageName, getSizeOfSurroundingTryBlock, getSizeOfSurroundingTryBlock, getSourceFile, getStringFromIndex, getSuperclassName, getSurroundingCaughtExceptions, getSurroundingCaughtExceptions, getSurroundingCaughtExceptionTypes, getSurroundingTryBlock, getSurroundingTryBlock, getThisClass, getXClass, getXField, getXMethod, hasInterestingClass, hasInterestingMethod, isVisitMethodsInCallOrder, setupVisitorForClass, setVisitMethodsInCallOrder, shouldVisit, toString, visitAfter, visitAfter, visitAnnotationDefault, visitAnnotationEntry, visitBootstrapMethods, visitConstantInvokeDynamic, visitConstantMethodHandle, visitConstantMethodType, visitConstantModule, visitConstantPackage, visitConstantPool, visitEnclosingMethod, visitingField, visitingMethod, visitInnerClasses, visitJavaClass, visitLineNumberTable, visitLocalVariableTable, visitMethodParameters, visitParameterAnnotationEntry, visitStackMap, visitStackMapEntry

Methods inherited from class BetterVisitor

clone, report, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visit, visitCodeException, visitConstantClass, visitConstantDouble, visitConstantFieldref, visitConstantFloat, visitConstantInteger, visitConstantInterfaceMethodref, visitConstantLong, visitConstantMethodref, visitConstantNameAndType, visitConstantString, visitConstantUtf8, visitConstantValue, visitDeprecated, visitExceptionTable, visitField, visitInnerClass, visitLineNumber, visitLocalVariable, visitLocalVariableTypeTable, visitSignature, visitSourceFile, visitSynthetic, visitUnknown

Methods inherited from class Object

equals, finalize, getClass, hashCode, notify, notifyAll, wait, wait, wait

Methods inherited from interface org.apache.bcel.classfile.Visitor

visitConstantDynamic, visitMethodParameter, visitModule, visitModuleExports, visitModuleMainClass, visitModuleOpens, visitModulePackages, visitModuleProvides, visitModuleRequires, visitNestHost, visitNestMembers, visitRecord, visitRecordComponent, visitStackMapType

Field Details

NODELIST_GET_LENGTH

private static final MethodDescriptor NODELIST_GET_LENGTH

PATTERN_COMPILE

private static final MethodDescriptor PATTERN_COMPILE

PATTERN_COMPILE_2

private static final MethodDescriptor PATTERN_COMPILE_2

PATTERN_MATCHES

private static final MethodDescriptor PATTERN_MATCHES

STRING_REPLACEALL

private static final MethodDescriptor STRING_REPLACEALL

STRING_REPLACEFIRST

private static final MethodDescriptor STRING_REPLACEFIRST

STRING_MATCHES

private static final MethodDescriptor STRING_MATCHES

STRING_SPLIT

private static final MethodDescriptor STRING_SPLIT

STRING_SPLIT_2

private static final MethodDescriptor STRING_SPLIT_2

implicitPatternMethods

private static final Set<MethodDescriptor> implicitPatternMethods

methods

private static final List<MethodDescriptor> methods

matched

private SortedMap<Integer, BugInstance> matched

conditions

private SortedMap<Integer,Integer> conditions

sources

private SortedMap<Integer,Integer> sources

bugReporter

private final BugReporter bugReporter

Constructor Details

InefficientInitializationInsideLoop

public InefficientInitializationInsideLoop(BugReporter bugReporter)

Method Details

visitClassContext

public void visitClassContext(ClassContext classContext)

Description copied from interface: Detector

Visit the ClassContext for a class which should be analyzed for instances of bug patterns.

Specified by:

visitClassContext in interface Detector

Overrides:

visitClassContext in class BytecodeScanningDetector

Parameters:

classContext - the ClassContext

visitMethod

public void visitMethod(org.apache.bcel.classfile.Method obj)

Specified by:

visitMethod in interface org.apache.bcel.classfile.Visitor

Overrides:

visitMethod in class BetterVisitor

isFastPath

private boolean isFastPath(String regex)

Since JDK 1.7 there's a special branch in String.split which works very fast for one-character pattern We do not report a bug if this case takes place (in fact precompilation will make split much slower since this fast path doesn't use regexp engine at all)

Parameters:

regex - regex to test whether it's suitable for the fast path

Returns:

true if fast path is possible

sawOpcode

public void sawOpcode(int seen)

Description copied from class: OpcodeStackDetector

By default, this method will not be called when stack is TOP. To change this behavior, override #beforeOpcode(int) and change to return true even if stack is TOP.

see Using FindBugs for Research to learn lattice and what TOP means.

Specified by:

sawOpcode in class OpcodeStackDetector

See Also:

• OpcodeStackDetector.beforeOpcode(int)

getFirstArgument

private String getFirstArgument()

Returns:

first argument of the called method if it's a constant

hasConstantArguments

private boolean hasConstantArguments()

Returns:

true if only constants are passed to the called method