Subject: CVE-2024-38565: wifi: ar5523: enable proper endpoint verification

From: Greg Kroah-Hartman <[email-masked]>

Description
===========

In the Linux kernel, the following vulnerability has been resolved:

wifi: ar5523: enable proper endpoint verification

Syzkaller reports [1] hitting a warning about an endpoint in use
not having an expected type to it.

Fix the issue by checking for the existence of all proper
endpoints with their according types intact.

Sadly, this patch has not been tested on real hardware.

[1] Syzkaller report:
------------[ cut here ]------------
usb 1-1: BOGUS urb xfer, pipe 3 != type 1
WARNING: CPU: 0 PID: 3643 at drivers/usb/core/urb.c:504 usb_submit_urb+0xed6/0x1880 drivers/usb/core/urb.c:504
...
Call Trace:
 <TASK>
 ar5523_cmd+0x41b/0x780 drivers/net/wireless/ath/ar5523/ar5523.c:275
 ar5523_cmd_read drivers/net/wireless/ath/ar5523/ar5523.c:302 [inline]
 ar5523_host_available drivers/net/wireless/ath/ar5523/ar5523.c:1376 [inline]
 ar5523_probe+0x14b0/0x1d10 drivers/net/wireless/ath/ar5523/ar5523.c:1655
 usb_probe_interface+0x30f/0x7f0 drivers/usb/core/driver.c:396
 call_driver_probe drivers/base/dd.c:560 [inline]
 really_probe+0x249/0xb90 drivers/base/dd.c:639
 __driver_probe_device+0x1df/0x4d0 drivers/base/dd.c:778
 driver_probe_device+0x4c/0x1a0 drivers/base/dd.c:808
 __device_attach_driver+0x1d4/0x2e0 drivers/base/dd.c:936
 bus_for_each_drv+0x163/0x1e0 drivers/base/bus.c:427
 __device_attach+0x1e4/0x530 drivers/base/dd.c:1008
 bus_probe_device+0x1e8/0x2a0 drivers/base/bus.c:487
 device_add+0xbd9/0x1e90 drivers/base/core.c:3517
 usb_set_configuration+0x101d/0x1900 drivers/usb/core/message.c:2170
 usb_generic_driver_probe+0xbe/0x100 drivers/usb/core/generic.c:238
 usb_probe_device+0xd8/0x2c0 drivers/usb/core/driver.c:293
 call_driver_probe drivers/base/dd.c:560 [inline]
 really_probe+0x249/0xb90 drivers/base/dd.c:639
 __driver_probe_device+0x1df/0x4d0 drivers/base/dd.c:778
 driver_probe_device+0x4c/0x1a0 drivers/base/dd.c:808
 __device_attach_driver+0x1d4/0x2e0 drivers/base/dd.c:936
 bus_for_each_drv+0x163/0x1e0 drivers/base/bus.c:427
 __device_attach+0x1e4/0x530 drivers/base/dd.c:1008
 bus_probe_device+0x1e8/0x2a0 drivers/base/bus.c:487
 device_add+0xbd9/0x1e90 drivers/base/core.c:3517
 usb_new_device.cold+0x685/0x10ad drivers/usb/core/hub.c:2573
 hub_port_connect drivers/usb/core/hub.c:5353 [inline]
 hub_port_connect_change drivers/usb/core/hub.c:5497 [inline]
 port_event drivers/usb/core/hub.c:5653 [inline]
 hub_event+0x26cb/0x45d0 drivers/usb/core/hub.c:5735
 process_one_work+0x9bf/0x1710 kernel/workqueue.c:2289
 worker_thread+0x669/0x1090 kernel/workqueue.c:2436
 kthread+0x2e8/0x3a0 kernel/kthread.c:376
 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:306
 </TASK>

The Linux kernel CVE team has assigned CVE-2024-38565 to this issue.

Affected and fixed versions
===========================

	Issue introduced in 3.8 with commit b7d572e1871d and fixed in 4.19.316 with commit 79ddf5f2020f
	Issue introduced in 3.8 with commit b7d572e1871d and fixed in 5.4.278 with commit 68a5a00c5d38
	Issue introduced in 3.8 with commit b7d572e1871d and fixed in 5.10.219 with commit ee25389df801
	Issue introduced in 3.8 with commit b7d572e1871d and fixed in 5.15.161 with commit b4c24de37a6b
	Issue introduced in 3.8 with commit b7d572e1871d and fixed in 6.1.93 with commit 34f7ebff1b96
	Issue introduced in 3.8 with commit b7d572e1871d and fixed in 6.6.33 with commit b33a81e4ecfb
	Issue introduced in 3.8 with commit b7d572e1871d and fixed in 6.8.12 with commit beeed260b92a
	Issue introduced in 3.8 with commit b7d572e1871d and fixed in 6.9.3 with commit 7bbf76c9bb2c
	Issue introduced in 3.8 with commit b7d572e1871d and fixed in 6.10 with commit e120b6388d7d

Please see https://www.kernel.org for a full list of currently supported
kernel versions by the kernel community.

Unaffected versions might change over time as fixes are backported to
older supported kernel versions.  The official CVE entry at
	https://cve.org/CVERecord/?id=CVE-2024-38565
will be updated if fixes are backported, please check that for the most
up to date information about this issue.

Affected files
==============

The file(s) affected by this issue are:
	drivers/net/wireless/ath/ar5523/ar5523.c

Mitigation
==========

The Linux kernel CVE team recommends that you update to the latest
stable kernel version for this, and many other bugfixes.  Individual
changes are never tested alone, but rather are part of a larger kernel
release.  Cherry-picking individual commits is not recommended or
supported by the Linux kernel community at all.  If however, updating to
the latest release is impossible, the individual changes to resolve this
issue can be found at these commits:
	https://git.kernel.org/stable/c/79ddf5f2020fd593d50f1363bb5131283d74f78f
	https://git.kernel.org/stable/c/68a5a00c5d38978a3f8460c6f182f7beec8688ff
	https://git.kernel.org/stable/c/ee25389df80138907bc9dcdf4a2be2067cde9a81
	https://git.kernel.org/stable/c/b4c24de37a6bb383394a6fef2b85a6db41d426f5
	https://git.kernel.org/stable/c/34f7ebff1b9699e0b89fa58b693bc098c2f5ec72
	https://git.kernel.org/stable/c/b33a81e4ecfb022b028cae37d1c1ce28ac1b359d
	https://git.kernel.org/stable/c/beeed260b92af158592f5e8d2dab65dae45c6f70
	https://git.kernel.org/stable/c/7bbf76c9bb2c58375e183074e44f9712483f0603
	https://git.kernel.org/stable/c/e120b6388d7d88635d67dcae6483f39c37111850