Subject: CVE-2023-52860: drivers/perf: hisi: use cpuhp_state_remove_instance_nocalls() for hisi_hns3_pmu uninit process

From: Greg Kroah-Hartman <[email-masked]>

Description
===========

In the Linux kernel, the following vulnerability has been resolved:

drivers/perf: hisi: use cpuhp_state_remove_instance_nocalls() for hisi_hns3_pmu uninit process

When tearing down a 'hisi_hns3' PMU, we mistakenly run the CPU hotplug
callbacks after the device has been unregistered, leading to fireworks
when we try to execute empty function callbacks within the driver:

  | Unable to handle kernel NULL pointer dereference at virtual address 0000000000000000
  | CPU: 0 PID: 15 Comm: cpuhp/0 Tainted: G        W  O      5.12.0-rc4+ #1
  | Hardware name:  , BIOS KpxxxFPGA 1P B600 V143 04/22/2021
  | pstate: 80400009 (Nzcv daif +PAN -UAO -TCO BTYPE=--)
  | pc : perf_pmu_migrate_context+0x98/0x38c
  | lr : perf_pmu_migrate_context+0x94/0x38c
  |
  | Call trace:
  |  perf_pmu_migrate_context+0x98/0x38c
  |  hisi_hns3_pmu_offline_cpu+0x104/0x12c [hisi_hns3_pmu]

Use cpuhp_state_remove_instance_nocalls() instead of
cpuhp_state_remove_instance() so that the notifiers don't execute after
the PMU device has been unregistered.

[will: Rewrote commit message]

The Linux kernel CVE team has assigned CVE-2023-52860 to this issue.

Affected and fixed versions
===========================

	Issue introduced in 6.0 with commit 66637ab137b4 and fixed in 6.1.63 with commit 4589403a343b
	Issue introduced in 6.0 with commit 66637ab137b4 and fixed in 6.5.12 with commit 3f5827371763
	Issue introduced in 6.0 with commit 66637ab137b4 and fixed in 6.6.2 with commit d04ff5437a45
	Issue introduced in 6.0 with commit 66637ab137b4 and fixed in 6.7 with commit 50b560783f7f

Please see https://www.kernel.org for a full list of currently supported
kernel versions by the kernel community.

Unaffected versions might change over time as fixes are backported to
older supported kernel versions.  The official CVE entry at
	https://cve.org/CVERecord/?id=CVE-2023-52860
will be updated if fixes are backported, please check that for the most
up to date information about this issue.

Affected files
==============

The file(s) affected by this issue are:
	drivers/perf/hisilicon/hns3_pmu.c

Mitigation
==========

The Linux kernel CVE team recommends that you update to the latest
stable kernel version for this, and many other bugfixes.  Individual
changes are never tested alone, but rather are part of a larger kernel
release.  Cherry-picking individual commits is not recommended or
supported by the Linux kernel community at all.  If however, updating to
the latest release is impossible, the individual changes to resolve this
issue can be found at these commits:
	https://git.kernel.org/stable/c/4589403a343bb0c72a6faf5898386ff964d4e01a
	https://git.kernel.org/stable/c/3f5827371763f2d9c70719c270055a81d030f3d0
	https://git.kernel.org/stable/c/d04ff5437a45f275db5530efb49b68d0ec851f6f
	https://git.kernel.org/stable/c/50b560783f7f71790bcf70e9e9855155fb0af8c1