     Rules for commits on the xmlsec module
     =========================================

0) DO NOT COMMIT DIRECTLY !
If you have a patch send a mail to xmlsec@aleksey.com mailing 
list (you must be subscribed to the list, go to 
http://www.aleksey.com/mailman/listinfo/xmlsec to subscribe).

If there is a problem in xmlsec module that prevents you
from building other major components then feel free to patch
first and then send a mail. This is an EXCEPTIONAL case and
you should be VERY carefull when you are doing this.

Igor Zlatkovic get an exception for the send before commit rule.

1) Coding style.
    - Formatting. Just for clarification, the formating is:

	tab size=8;indentation=4;insert spaces=yes 

    - Use explicit "!= NULL", "!= 0", etc. This makes code
    easier to read and remove warnings on some platform. 
    Example:
	BAD:
	    if(a) 
	GOOD:
	    if(a != NULL)
	or 
	    if(a != 0)
   
   - Put figure brackets '{}' even if you have only one operator
   in "if", "for", etc. This also makes code easier to read and 
   saves a lot of time when you need to quickly change something. 
   Example:
	BAD:
             if(a != NULL) 
		xmlFree(a);
	GOOD:
             if(a != NULL) {
		xmlFree(a);
	    }
    
    - Use round brackets '()' in conditions to show the precedence order.
    I don't remember what goes first '<<' or '*', do you?
    Example:
	BAD:
            if(privkey == NULL || pubkey == NULL)
	GOOD:
	    if((privkey == NULL) || (pubkey == NULL))
   
   - Use round brackets '()' for "return". 
   Example:
	BAD:
	    return 0;
	GOOD:
	    return(0);
    
    - Check for warnings! Use "--enable-pedantic" option
    for "configure.in" script to enable as much warnings as possible.
    Your patch should produce no new warnings and if you'll
    see something that you can fix, then do it.
    
    - Check for memory leaks. There is a built in support for 
    valgrind (http://devel-home.kde.org/~sewardj/). In order to use it,
    use "enable_static_linking" option for "configure.in" script to 
    force static linking of xmlsec command line utility and run 
    "make memcheck" from the top xmlsec source folder. The results are printed
    at the end. More detailed logs could be found in /tmp/test*.log files.

2) Coding practice
    - You should trust nobody! Anyone can fool you: user or another application
    might provide you incorrect data; call to xmlsec or system function might 
    fail with an error code; worse, the same call might fail but the return 
    code is "success" and so on. The patch fixes a lot of places where the 
    original code failed to check input data or function return values. 
    One of my favorite examples is the code that *silently* assumed that 
    base64 decoded value of a RSA public exponent obtained from XML fits 
    in a DWORD. And after that the code did memcpy to copy from xmlSecBuffer 
    to a DWORD variable *without* checking how much data are actualy copied! 
    The trivial DoS attack (at least DoS!!!) is to put very long base64 string
    in XML file and enjoy the server crash.
    One of the strongest sides of xmlsec library is that there are very few 
    known ways to crash it (and all of them are related to running the 
    application in an environment with a very limited memory to force a malloc 
    failure). To be a little paranoid is good in this context :)
    
    - malloc/free vs. xmlMalloc/xmlFree
    xmlsec library use libxml2 memory management functions. This provides an 
    easy way to replace default memory management functions with custom ones. 
    And this might be very usefull in some cases.
    Note that crypto library might use a different memory management
    functions! Be very carefully to do not mix them (i.e. get memory
    allocated by crypto library function and free it with xmFree).

    - Errors reporting (XMLSEC_ERRORS_R_XMLSEC_FAILED vs. XMLSEC_ERRORS_R_CRYPTO_FAILED)
    The correct usage rule is:
	if the failed function starts with "xmlSec" then use
    	    XMLSEC_ERRORS_R_XMLSEC_FAILED
	else if it is xmlMalloc/xmlFree/xmlStrdup/etc then use
            XMLSEC_ERRORS_R_MALLOC_FAILED
	else if the function starts with "xml" or "xslt" (i.e. it comes 
	from libxml or libxslt) then use
	    XMLSEC_ERRORS_R_XML_FAILED
	else if it is related to IO (fopen, fread, fwrite, etc.) then use
	    XMLSEC_ERRORS_R_IO_FAILED
	else if the function could be used only from xmlsec-crypto (i.e. 
	it is crypto engine related) then use
	    XMLSEC_ERRORS_R_CRYPTO_FAILED
	else if there is another reason (invalid data, invalid size, etc.)
	    corresponding error reason should be used
	else
	    it is something new and should be discussed
	fi						    
    Correct error reason is very important. For example,  some applications 
    ignore all the XMLSEC_ERRORS_R_XMLSEC_FAILED errors to get to the bottom of
    the errors stack and report the actual problem.
							    
    - Errors reporting: "size=%d;error=%d" instead of "size %d, error: %d":
    It would be great if xmlsec-crypto libraries can follow the error message 
    standard adopted in the other files of xmlsec library: 
	"<name1>=<value1>;<name2>=<value2>;..."
    This greatly helps when one needs to write a logs parser. For example, to 
    find the reason of memory allocation failures.				    

3) Preparing and submiting a patch.
If you want to submit a patch please do following:
  - Get a CVS source copy (see http://www.aleksey.com/xmlsec/download.html).
    It's much easier to prepare patch from CVS than to diff two set of files.
  - Test your patch! Make sure that your patch complain with xmlsec coding 
    style (see above) and that you don't introduce new warnings or memory leaks
    (also see above). If you have a new functionality in the patch,
    do not forget to add a test case(s) in the xmlsec test suite.
  - If you have new files in your patch mark them "to be added" with 
	cvs add <filename>
    command. If you have binary files, do not forget to use '-kb' option
	cvs add -kb <filename>
    If you have new folders in your patch and you don't have write access to CVS, 
    send a mail to xmlsec@aleksey.com and I'll create them for you.
  - Prepare patch by running diff command from the top of the source tree:
	cvs -z3 diff -uN [<file or folder names>...] > <output filename>
    The file or folder names are optional and you can use it to save
    yourself some time. "-u" option produces a human readble diff,
    "-N" option includes to the diff new files created on prevous step.
    Finally, "-z3" forces cvs to compress the network traffic and make things
    faster. Please use ".diff" extension in your output filename. This will
    add colors to my editor when I would be looking at it :)
  - Gzip or zip your diff file! Don't send plain diff file because some mailers
    corrupt it.
  - Send your patch along with a short description of the problem or feature
    you are fixing/implementing to the xmlsec@aleksey.com mailing list 
    (you must be subscribed to the list, go to http://www.aleksey.com/mailman/listinfo/xmlsec to subscribe).
    If you are fixing a bug, it might be a good idea to bugzilla it first
    (http://www.aleksey.com/xmlsec/bugs.html) for the record. Do not forget
    to put link or bug number in your message if the bug is in bugzilla.
    


    
    

