iBATIS JPetstore Demo Portlet

## PMD Results

The following document contains the results of PMD.

## Summary

Files | Errors
--- | ---
12 | 14

## Files

Files | Violations
--- | ---
com/ibatis/jpetstore/domain/CartItem.java | 1
com/ibatis/jpetstore/domain/LineItem.java | 1
com/ibatis/jpetstore/domain/Order.java | 1
com/ibatis/jpetstore/persistence/DaoConfig.java | 1
com/ibatis/jpetstore/presentation/CartBean.java | 1
com/ibatis/jpetstore/presentation/OrderBean.java | 3
com/ibatis/struts/BaseBean.java | 1
com/ibatis/struts/BeanAction.java | 1
com/ibatis/struts/httpmap/CookieMap.java | 1
com/ibatis/struts/httpmap/ParameterMap.java | 1
com/ibatis/struts/httpmap/RequestMap.java | 1
com/ibatis/struts/httpmap/SessionMap.java | 1

### com/ibatis/jpetstore/domain/CartItem.java

Violation | Line
--- | ---
Avoid if (x != y) ..; else ..; | 74

### com/ibatis/jpetstore/domain/LineItem.java

Violation | Line
--- | ---
Avoid if (x != y) ..; else ..; | 107

### com/ibatis/jpetstore/domain/Order.java

Violation | Line
--- | ---
A high number of public methods and attributes in an object can indicate the class may need to be broken up for exhaustive testing may prove difficult. | 330

### com/ibatis/jpetstore/persistence/DaoConfig.java

Violation | Line
--- | ---
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor to silence this warning. | 50

### com/ibatis/jpetstore/presentation/CartBean.java

Violation | Line
--- | ---
Avoid empty catch blocks | 111

### com/ibatis/jpetstore/presentation/OrderBean.java

Violation | Line
--- | ---
Avoid if (x != y) ..; else ..; | 129
Avoid if (x != y) ..; else ..; | 146
Avoid if (x != y) ..; else ..; | 148

### com/ibatis/struts/BaseBean.java

Violation | Line
--- | ---
The same String literal appears 4 times in this file; the first occurrence is on line 63 | 63

### com/ibatis/struts/BeanAction.java

Violation | Line
--- | ---
Deeply nested if..then statements are hard to read | 148

### com/ibatis/struts/httpmap/CookieMap.java

Violation | Line
--- | ---
No need to import a type that's in the same package | 19

### com/ibatis/struts/httpmap/ParameterMap.java

Violation | Line
--- | ---
No need to import a type that's in the same package | 19

### com/ibatis/struts/httpmap/RequestMap.java

Violation | Line
--- | ---
No need to import a type that's in the same package | 19

### com/ibatis/struts/httpmap/SessionMap.java

Violation | Line
--- | ---
No need to import a type that's in the same package | 19