Common Utilities and Interfaces

## PMD Results

The following document contains the results of PMD.

## Summary

Files | Errors
--- | ---
7 | 25

## Files

Files | Violations
--- | ---
org/apache/portals/bridges/beans/TabBean.java | 1
org/apache/portals/bridges/common/GenericServletPortlet.java | 12
org/apache/portals/bridges/common/ScriptPostProcess.java | 7
org/apache/portals/bridges/util/NamespacedNamesEnumeration.java | 2
org/apache/portals/bridges/util/PortletWindowUtils.java | 1
org/apache/portals/bridges/util/PreferencesHelper.java | 1
org/apache/portals/messaging/PortletMessaging.java | 1

### org/apache/portals/bridges/beans/TabBean.java

Violation | Line
--- | ---
Ensure you override both equals() and hashCode() | 55

### org/apache/portals/bridges/common/GenericServletPortlet.java

Violation | Line
--- | ---
Avoid instantiating Boolean objects; you can usually invoke Boolean.valueOf() instead. | 167
Avoid unnecessary comparisons in boolean expressions | 200
Avoid empty 'if' statements | 211
Avoid unnecessary return statements | 218
Avoid unnecessary comparisons in boolean expressions | 232
Avoid unnecessary return statements | 250
Avoid unnecessary comparisons in boolean expressions | 272
Avoid unnecessary return statements | 288
Avoid unnecessary comparisons in boolean expressions | 310
Avoid unnecessary return statements | 327
Avoid unnecessary comparisons in boolean expressions | 349
Avoid unnecessary return statements | 366

### org/apache/portals/bridges/common/ScriptPostProcess.java

Violation | Line
--- | ---
Avoid if (x != y) ..; else ..; | 51
The same String literal appears 5 times in this file; the first occurrence is on line 80 | 80
Avoid really long methods. | 98
Avoid using 'if...else' statements without curly braces | 140
Avoid using if statements without curly braces | 141
Avoid unnecessary comparisons in boolean expressions | 163
Avoid unnecessary comparisons in boolean expressions | 167

### org/apache/portals/bridges/util/NamespacedNamesEnumeration.java

Violation | Line
--- | ---
Avoid calls to overridable methods during construction | 38
Deeply nested if..then statements are hard to read | 50

### org/apache/portals/bridges/util/PortletWindowUtils.java

Violation | Line
--- | ---
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor to silence this warning. | 88

### org/apache/portals/bridges/util/PreferencesHelper.java

Violation | Line
--- | ---
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor to silence this warning. | 70

### org/apache/portals/messaging/PortletMessaging.java

Violation | Line
--- | ---
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor to silence this warning. | 108