JSF Bridge

## PMD Results

The following document contains the results of PMD.

## Summary

Files | Errors
--- | ---
15 | 71

## Files

Files | Violations
--- | ---
org/apache/portals/bridges/jsf/AbstractAttributeMap.java | 3
org/apache/portals/bridges/jsf/ApplicationMap.java | 3
org/apache/portals/bridges/jsf/FacesPortlet.java | 14
org/apache/portals/bridges/jsf/InitParameterMap.java | 3
org/apache/portals/bridges/jsf/PortletExternalContextImpl.java | 6
org/apache/portals/bridges/jsf/PortletFacesContextImpl.java | 6
org/apache/portals/bridges/jsf/PortletUIViewRoot.java | 1
org/apache/portals/bridges/jsf/RequestMap.java | 4
org/apache/portals/bridges/jsf/RequestParameterMap.java | 3
org/apache/portals/bridges/jsf/RequestParameterValuesMap.java | 3
org/apache/portals/bridges/jsf/ServletCookieMap.java | 3
org/apache/portals/bridges/jsf/ServletExternalContextImpl.java | 7
org/apache/portals/bridges/jsf/ServletFacesContextImpl.java | 6
org/apache/portals/bridges/jsf/ServletRequestMap.java | 2
org/apache/portals/bridges/jsf/SessionMap.java | 7

### org/apache/portals/bridges/jsf/AbstractAttributeMap.java

Violation | Line
--- | ---
Avoid if (x != y) ..; else ..; | 100
Avoid if (x != y) ..; else ..; | 124
Avoid if (x != y) ..; else ..; | 180

### org/apache/portals/bridges/jsf/ApplicationMap.java

Violation | Line
--- | ---
No need to import a type that's in the same package | 23
Avoid if (x != y) ..; else ..; | 63
Avoid if (x != y) ..; else ..; | 101

### org/apache/portals/bridges/jsf/FacesPortlet.java

Violation | Line
--- | ---
The class 'FacesPortlet' has a Cyclomatic Complexity of 4 (Highest = 11). | 61
Avoid unused private fields such as 'application' | 165
Avoid really long methods. | 452
The method 'process' has a Cyclomatic Complexity of 11. | 452
Avoid unused local variables such as 'defaultView' | 458
Avoid unused local variables such as 'actionResponse' | 501
Avoid if (x != y) ..; else ..; | 582
Avoid if (x != y) ..; else ..; | 593
Avoid reassigning parameters such as 'defaultView' | 616
Avoid if (x != y) ..; else ..; | 628
Avoid if (x != y) ..; else ..; | 644
Avoid if (x != y) ..; else ..; | 653
Avoid if (x != y) ..; else ..; | 675
Avoid if (x != y) ..; else ..; | 684

### org/apache/portals/bridges/jsf/InitParameterMap.java

Violation | Line
--- | ---
No need to import a type that's in the same package | 23
Avoid if (x != y) ..; else ..; | 63
Avoid if (x != y) ..; else ..; | 95

### org/apache/portals/bridges/jsf/PortletExternalContextImpl.java

Violation | Line
--- | ---
Avoid unused private fields such as 'requestCookieMap' | 92
Avoid unused private fields such as 'requestPathInfo' | 98
Avoid unused private fields such as 'requestServletPath' | 101
Avoid if (x != y) ..; else ..; | 404
Avoid if (x != y) ..; else ..; | 437
Avoid using 'if...else' statements without curly braces | 515

### org/apache/portals/bridges/jsf/PortletFacesContextImpl.java

Violation | Line
--- | ---
Avoid unused imports such as 'ActionRequest' | 37
Avoid calls to overridable methods during construction | 109
Avoid if (x != y) ..; else ..; | 197
Avoid using if statements without curly braces | 273
Avoid using if statements without curly braces | 278
Avoid if (x != y) ..; else ..; | 398

### org/apache/portals/bridges/jsf/PortletUIViewRoot.java

Violation | Line
--- | ---
Avoid using if statements without curly braces | 60

### org/apache/portals/bridges/jsf/RequestMap.java

Violation | Line
--- | ---
Avoid unused imports such as 'PortletContext' | 21
No need to import a type that's in the same package | 24
Avoid if (x != y) ..; else ..; | 61
Avoid if (x != y) ..; else ..; | 98

### org/apache/portals/bridges/jsf/RequestParameterMap.java

Violation | Line
--- | ---
No need to import a type that's in the same package | 23
Avoid if (x != y) ..; else ..; | 60
Avoid if (x != y) ..; else ..; | 91

### org/apache/portals/bridges/jsf/RequestParameterValuesMap.java

Violation | Line
--- | ---
No need to import a type that's in the same package | 23
Avoid if (x != y) ..; else ..; | 60
Avoid if (x != y) ..; else ..; | 91

### org/apache/portals/bridges/jsf/ServletCookieMap.java

Violation | Line
--- | ---
Avoid using if statements without curly braces | 47
Avoid using if statements without curly braces | 67
Avoid using if statements without curly braces | 100

### org/apache/portals/bridges/jsf/ServletExternalContextImpl.java

Violation | Line
--- | ---
Deeply nested if..then statements are hard to read | 111
Avoid using if statements without curly braces | 125
Avoid if (x != y) ..; else ..; | 139
Avoid using if statements without curly braces | 155
Avoid using if statements without curly braces | 159
The same String literal appears 15 times in this file; the first occurrence is on line 187 | 187
Avoid if (x != y) ..; else ..; | 418

### org/apache/portals/bridges/jsf/ServletFacesContextImpl.java

Violation | Line
--- | ---
Avoid calls to overridable methods during construction | 61
The same String literal appears 18 times in this file; the first occurrence is on line 80 | 80
Avoid if (x != y) ..; else ..; | 98
Avoid using if statements without curly braces | 140
Avoid using if statements without curly braces | 144
Avoid if (x != y) ..; else ..; | 259

### org/apache/portals/bridges/jsf/ServletRequestMap.java

Violation | Line
--- | ---
Avoid if (x != y) ..; else ..; | 57
Avoid if (x != y) ..; else ..; | 94

### org/apache/portals/bridges/jsf/SessionMap.java

Violation | Line
--- | ---
No need to import a type that's in the same package | 24
No need to import a type that's in the same package | 25
Avoid if (x != y) ..; else ..; | 65
Avoid calling toString() on String objects; this is unnecessary | 68
An empty statement (semicolon) not part of a loop | 96
Avoid if (x != y) ..; else ..; | 109
An empty statement (semicolon) not part of a loop | 112